[pull] main from remix-run:main - #314
Merged
Merged
Conversation
…15273) * fix: rank a static route above a dynamic param with a static suffix computeScore scored a segment such as :lang.xml as fully static because the paramRe anchor required the whole segment to be a bare param. compilePath compiles :lang.xml to a dynamic capture, so /:lang.xml tied with a truly static /sitemap.xml and the tie was broken by declaration order. A request for the literal /sitemap.xml could then match /:lang.xml with params { lang: 'sitemap' } instead of the static route, breaking the static-beats-dynamic invariant. Drop the trailing anchor so a segment counts as dynamic when it starts with a param token, matching compilePath and the rest of the router. * Sign the CLA * Add change file for suffixed param ranking * Apply suggestion from @brophdawg11 * Apply suggestion from @brophdawg11 * Handle dynamic+suffix vs dynamic --------- Co-authored-by: Matt Brophy <matt@brophy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )