Skip to content

[pull] main from remix-run:main - #314

Merged
pull[bot] merged 3 commits into
code:mainfrom
remix-run:main
Jul 2, 2026
Merged

[pull] main from remix-run:main#314
pull[bot] merged 3 commits into
code:mainfrom
remix-run:main

Conversation

@pull

@pull pull Bot commented Jul 2, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

brophdawg11 and others added 3 commits July 2, 2026 14:17
…15273)

* fix: rank a static route above a dynamic param with a static suffix

computeScore scored a segment such as :lang.xml as fully static because the
paramRe anchor required the whole segment to be a bare param. compilePath
compiles :lang.xml to a dynamic capture, so /:lang.xml tied with a truly
static /sitemap.xml and the tie was broken by declaration order. A request
for the literal /sitemap.xml could then match /:lang.xml with
params { lang: 'sitemap' } instead of the static route, breaking the
static-beats-dynamic invariant.

Drop the trailing anchor so a segment counts as dynamic when it starts with
a param token, matching compilePath and the rest of the router.

* Sign the CLA

* Add change file for suffixed param ranking

* Apply suggestion from @brophdawg11

* Apply suggestion from @brophdawg11

* Handle dynamic+suffix vs dynamic

---------

Co-authored-by: Matt Brophy <matt@brophy.org>
@pull pull Bot locked and limited conversation to collaborators Jul 2, 2026
@pull pull Bot added the ⤵️ pull label Jul 2, 2026
@pull
pull Bot merged commit 0cd1157 into code:main Jul 2, 2026
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants